fix(filesystem): handle negative values in formatSize()#3231
Open
nulone wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(filesystem): handle negative values in formatSize()#3231nulone wants to merge 1 commit intomodelcontextprotocol:mainfrom
nulone wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Return '0 B' for negative byte values instead of 'NaN B'. File sizes cannot be negative, so this is a safe default. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nulone
force-pushed
the
fix/filesystem-format-size-negative
branch
from
2ea0092 to
b5d0244
Compare
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
formatSize()returned "NaN B" for negative byte values. Now returns "0 B" since file sizes cannot be negative.Server Details
Motivation and Context
Invalid input should not produce "NaN B" in UI. File sizes cannot be negative, so returning "0 B" is a safe default.
How Has This Been Tested?
Breaking Changes
None.
Types of changes
Checklist